Skip to content

config: runtime: base: lava: improve timeout calculation #2917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

a-wai
Copy link
Contributor

@a-wai a-wai commented Jun 30, 2025

Currently, the full job timeout is set to 30 minutes by default, or job_timeout + 15 if job_timeout is defined and exceeds 30 minutes. Those 15 minutes are meant to account for artifacts download and device boot time, but if the test is supposed to last 30 minutes (or almost), then the job might time out before the test is complete. Fix this by making 15 the minimum value for job_timeout (and keep falling back to the default 30 minutes otherwise).

Also add an additional 10 minutes to account for coverage data post-processing and upload (which usually takes 5-6 minutes) when coverage support is enabled.

@a-wai a-wai requested review from nuclearcat and laura-nao June 30, 2025 14:59
Copy link
Contributor

@pawiecz pawiecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I haven't been tracking time spent by the LAVA TestJobs in a while (it will need to be readjusted in case of major changes in the infra)

Currently, the full job timeout is set to 30 minutes by default, or
`job_timeout + 15` if `job_timeout` is defined and exceeds 30 minutes.
Those 15 minutes are meant to account for artifacts download and device
boot time, but if the test is supposed to last 30 minutes (or almost),
then the job might time out before the test is complete. Fix this by
making *15* the minimum value for `job_timeout` (and keep falling back
to the default 30 minutes otherwise).

Also add an additional 10 minutes to account for coverage data
post-processing and upload (which usually takes 5-6 minutes) when
coverage support is enabled.

Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
@a-wai a-wai force-pushed the lava-improve-timeout-calc branch from 85278d3 to 0202e9b Compare July 10, 2025 07:29
@JenySadadia JenySadadia added this pull request to the merge queue Jul 10, 2025
Merged via the queue into kernelci:main with commit 799c9e7 Jul 10, 2025
4 checks passed
@a-wai a-wai deleted the lava-improve-timeout-calc branch July 10, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants